-
Notifications
You must be signed in to change notification settings - Fork 135
Enable Variable Channel Spacing in STARBackend
#862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable Variable Channel Spacing in STARBackend
#862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces configurable channel spacing for the STAR backend by replacing hardcoded 9mm spacing values with a configurable channel_minimum_y_spacing attribute. This enables more flexible hardware configuration while maintaining safety constraints.
Changes:
- Added
channel_minimum_y_spacingattribute initialization in the setup method - Replaced all hardcoded 9mm spacing values with the new configurable attribute
- Updated assertion error messages to use the configurable spacing value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| await self.initialize_pip() | ||
| self._channel_minimum_y_spacing = ( | ||
| 9.0 # TODO: identify from machine directly to override default | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the required method didn't exist until I created it today in #870 (i.e. after this PR was created)
And because it would add multiple changes in the same PR (Enabling variable channel spacing | enabling detection of minimum possible y spacing - next one: merging the two into auto-detection of minimum y spacing during single-channel setup)
I've laid out the step by step plan here: #822 (comment)
No description provided.